Changeset 2aacbffc4255e2ba9a9963172cfd084bcbce51e3

Timestamp:

07/11/09 16:41:54 (3 years ago)

Author:

Nedko Arnaudov <nedko@…>

Children:

b4eb0c7aa9dbeccc940447bfb888170ebe78fe90

Parents:

8c53171ad94ee9d627dcb2209acd6570af25ab4f

git-committer:

Nedko Arnaudov <nedko@arnaudov.name> / 2009-07-11T16:41:54Z+0300

Message:

Wait child zombies

Files:

• lv2_ui.c (modified) (5 diffs)

lv2_ui.c

@@ -50 +50 @@
 
 #include <sys/types.h>
+#include <sys/wait.h>
 #if defined(FORK_TIME_MEASURE)
 # include <sys/time.h>
@@ -78 +79 @@
   int send_pipe;             /* the pipe end that is used for sending messages to UI */
   int recv_pipe;             /* the pipe end that is used for receiving messages from UI */
+
+  pid_t pid;
 };
 
@@ -156 +159 @@
   else if (!strcmp(msg, "exiting"))
   {
+    pid_t ret;
+    int i;
+
     //printf("got UI exit notification\n");
+
+    /* wait tree seconds for child to exit, we dont like zombie processes */
+    for (i = 0; i < 30; i++)
+    {
+      //fprintf(stderr, "waitpid(%d): %d\n", (int)control_ptr->pid, i);
+
+      ret = waitpid(control_ptr->pid, NULL, WNOHANG);
+      if (ret != 0)
+      {
+        if (ret == -1)
+        {
+          fprintf(stderr, "waitpid(%d) failed: %s\n", (int)control_ptr->pid, strerror(errno));
+        }
+        else if (ret == control_ptr->pid)
+        {
+          control_ptr->pid = -1;
+        }
+        else
+        {
+          fprintf(stderr, "we have waited for child pid %d to exit but we got pid %d instead\n", (int)control_ptr->pid, (int)ret);
+        }
+
+        break;
+      }
+
+      //fprintf(stderr, "wait 100 ms ...\n");
+      usleep(100000);           /* wait 100 ms */
+    }
+
+    if (control_ptr->pid != -1)
+    {
+      fprintf(stderr, "we have waited for child pid %d to exit for 3 seconds and we are giving up\n", (int)control_ptr->pid);
+    }
+
     control_ptr->running = false;
     control_ptr->visible = false;
@@ -327 +367 @@
   control_ptr->visible = false;
 
+  control_ptr->pid = -1;
+
   argv[0] = "python";
   argv[1] = filename;
@@ -377 +419 @@
 
   //fprintf(stderr, FORK_STR "()-ed child process: %d\n", ret);
+  control_ptr->pid = ret;
 
   /* fork duplicated the handles, close pipe ends that are used by the child process */